-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PE-D bug fix #213
PE-D bug fix #213
Conversation
Codecov Report
@@ Coverage Diff @@
## master #213 +/- ##
============================================
+ Coverage 70.51% 70.52% +0.01%
Complexity 718 718
============================================
Files 114 114
Lines 2601 2602 +1
Branches 281 281
============================================
+ Hits 1834 1835 +1
Misses 662 662
Partials 105 105
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Well done on the UG changes and appointmentTime bug fix!
- EMAIL must contain email domain (eg. `@gmail.com`). | ||
- TAG must indicate Priority Level of the Patient and be one of the following: | ||
- Low | ||
- Medium | ||
- High | ||
- EMERGENCY_CONTACT must contain valid emergency contact number, which needs to be a valid phone number. | ||
- EMERGENCY_CONTACT must contain valid emergency contact number, which needs to be a valid phone number. This number can be the same the person's contact number. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we going to justify why? Or perhaps there is no real need to?
Fixes the issues assigned to me, raised by the PE-D testers.
Updated UG:
AppointmentTime: